Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/nvme list #7

Merged
merged 4 commits into from
Feb 14, 2022
Merged

Feature/nvme list #7

merged 4 commits into from
Feb 14, 2022

Conversation

harshitap26
Copy link
Collaborator

@harshitap26 harshitap26 commented Feb 14, 2022 •
edited
Loading

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#158

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested on linux environment with nvme library installed
  • ListNamespaceDevices and GetNamespaceData are successful

francis-nijay
francis-nijay previously approved these changes Feb 14, 2022
View reviewed changes
spriya-m
spriya-m suggested changes Feb 14, 2022
View reviewed changes
gonvme_tcp.go Outdated Show resolved Hide resolved
@francis-nijay francis-nijay merged commit 9781a85 into main Feb 14, 2022
@mjsdell mjsdell deleted the feature/nvme-list branch October 17, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spriya-m spriya-m spriya-m approved these changes

@francis-nijay francis-nijay francis-nijay approved these changes

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@kumarp20 kumarp20 Awaiting requested review from kumarp20 kumarp20 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshitap26 @francis-nijay @spriya-m